Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored cell.jsx to functional component #6182

Closed
wants to merge 8 commits into from

Conversation

Raman-Luhach
Copy link
Contributor

@Raman-Luhach Raman-Luhach commented Jul 22, 2024

Refactored cell.jsx from class-based to functional-based component.

This is my first contribution to volto. Please give feedback and I will try to rectify that.

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit f0f0ad6
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66a5e9a1965684000886eff1

@stevepiercy
Copy link
Collaborator

@Raman-Luhach thank you for your contribution! Here are some things to address.

The change log check fails with this message https://github.com/plone/volto/actions/runs/10047245268/job/27768503949?pr=6182. You need to move the change log entry to the appropriate package, packages/volto-slate, per Change log entry.

Next run acceptance tests locally before creating a pull request according to Acceptance tests. Two GitHub workflows currently fail. That could be a flaky test. When you run tests locally, it is easier to compare against GitHub workflows and debug the issue. If tests pass locally, but fail in GitHub workflows, then post a comment with details and ask for assistance if you need help.

Finally keep your feature branch current with main. See Update your pull request from your fork.

@stevepiercy
Copy link
Collaborator

@Raman-Luhach CI checks still fail. Please resolve them.

@stevepiercy
Copy link
Collaborator

@sneridagh this is another PR that was not listed in #4460, but that list may have been before the monorepo and splitting out volto-slate. Please advise.

@davisagli
Copy link
Member

This is already in progress in #4963

@davisagli davisagli closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants