Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added make i18n to volto #6274

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Added make i18n to volto #6274

merged 3 commits into from
Aug 30, 2024

Conversation

Faakhir30
Copy link
Contributor

Fixes #6263
Added make i18n to Volto's makefile.

sample output:


f@f:~/workspaces/oss/plone/plone-volto$ make i18n
make[1]: Entering directory '/home/f/workspaces/oss/plone/plone-volto/packages/volto'

> @plone/volto@18.0.0-alpha.42 i18n /home/f/workspaces/oss/plone/plone-volto/packages/volto
> rm -rf build/messages && NODE_ENV=production i18n

Extracting messages from source files...
Synchronizing messages to pot file...
Synchronizing messages to po files...
Generating the language JSON files...
Merging @plone/volto-slate locales for de
Merging @plone/volto-slate locales for en
done!
make[1]: Leaving directory '/home/f/workspaces/oss/plone/plone-volto/packages/volto'

Volto's default package-manager in package.json is pnpm, so using pnpm i18n

Will update in plone/documentation repo also once this is confirmed.

Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 22220ea
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66d17c65124d810008d0e8a9

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that this works.

I have a few suggestions, and once you make them, I'm happy to merge this PR. Thank you!

Makefile Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also do not include trim of whitespace in a pull request, as that just adds noise to what actually needs review. Instead create a separate PR for trims.

packages/volto/Makefile Outdated Show resolved Hide resolved
@Faakhir30 Faakhir30 requested a review from stevepiercy August 30, 2024 07:55
packages/volto/news/6274.internal Outdated Show resolved Hide resolved
@stevepiercy stevepiercy self-requested a review August 30, 2024 08:01
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's merge it when all checks pass.

@stevepiercy stevepiercy merged commit e49fb93 into plone:main Aug 30, 2024
44 checks passed
@Faakhir30 Faakhir30 deleted the make_i18n_command branch August 30, 2024 08:33
@stevepiercy
Copy link
Collaborator

@Faakhir30 would you also please submit a PR in plone/documentation at https://6.docs.plone.org/i18n-l10n/contributing-translations.html#translate-volto? Thank you!

@Faakhir30
Copy link
Contributor Author

@Faakhir30 would you also please submit a PR in plone/documentation at https://6.docs.plone.org/i18n-l10n/contributing-translations.html#translate-volto? Thank you!

yeah sure, it'll be done by today / tomorrow, thanks

sneridagh added a commit that referenced this pull request Sep 14, 2024
* main: (97 commits)
  Release 18.0.0-alpha.43
  Release @plone/slate 18.0.0-alpha.18
  Release @plone/client 1.0.0-alpha.17
  Added a notice in the upgrade guide for CookiePlone as the recommended way for generating projects and add-on boilerplate (#6286)
  Fix typo in Changelog for #6285 (#6287)
  Update to Volto 6.0.13 (#6285)
  Fix order component (#6284)
  Remove dangling `.only` in Cypress test (#6282)
  Empty GridBlocks will not be rendered in 'View' (#6280)
  Refactor Content upload modal  (#5047)
  Passes the `user` to the `restricted` function of the block settings (#6271)
  Refactored SelectMetadataField.jsx to functional component (#5570)
  Remove "Generate tabs for items other than folders" field from navigation control panel (#6278)
  Refactor DatetimeWidget (#6213)
  Added make i18n to volto (#6274)
  Place the actions-storybook in correct folder (#6275)
  Refactor ReferenceWidget (#5093)
  Fix error in SortOn component when there is no sort selected. (#6273)
  When user changes location, set the userSession.token value based on cookie (#6079)
  Trivial MyST syntax enhancement
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add a make command for yarn i18n, such as make i18n
2 participants