-
-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added make i18n to volto #6274
Added make i18n to volto #6274
Conversation
✅ Deploy Preview for plone-components canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm that this works.
I have a few suggestions, and once you make them, I'm happy to merge this PR. Thank you!
packages/volto/CHANGELOG.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not edit this file. See https://6.docs.plone.org/contributing/index.html#contributing-change-log-label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also do not include trim of whitespace in a pull request, as that just adds noise to what actually needs review. Instead create a separate PR for trims.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let's merge it when all checks pass.
@Faakhir30 would you also please submit a PR in |
yeah sure, it'll be done by today / tomorrow, thanks |
* main: (97 commits) Release 18.0.0-alpha.43 Release @plone/slate 18.0.0-alpha.18 Release @plone/client 1.0.0-alpha.17 Added a notice in the upgrade guide for CookiePlone as the recommended way for generating projects and add-on boilerplate (#6286) Fix typo in Changelog for #6285 (#6287) Update to Volto 6.0.13 (#6285) Fix order component (#6284) Remove dangling `.only` in Cypress test (#6282) Empty GridBlocks will not be rendered in 'View' (#6280) Refactor Content upload modal (#5047) Passes the `user` to the `restricted` function of the block settings (#6271) Refactored SelectMetadataField.jsx to functional component (#5570) Remove "Generate tabs for items other than folders" field from navigation control panel (#6278) Refactor DatetimeWidget (#6213) Added make i18n to volto (#6274) Place the actions-storybook in correct folder (#6275) Refactor ReferenceWidget (#5093) Fix error in SortOn component when there is no sort selected. (#6273) When user changes location, set the userSession.token value based on cookie (#6079) Trivial MyST syntax enhancement ...
Fixes #6263
Added make i18n to Volto's makefile.
sample output:
Volto's default package-manager in package.json is pnpm, so using
pnpm i18n
Will update in plone/documentation repo also once this is confirmed.