Volto form block fixes #6370
Open
Volto form block fixes #6370
+3,078
−402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
davisagli
requested changes
Oct 4, 2024
|
This PR should also render its Storybook. We recently merged a PR that should fix the pull request preview build on Netlify: The Netlify build currently fails to recognize changes in the most recent commit: |
robgietema
force-pushed
the
volto-form-block-fixes
branch
2 times, most recently
from
6d9bc8a to
be53373
Compare
robgietema
force-pushed
the
volto-form-block-fixes
branch
from
988b47e to
dd5a050
Compare
This caused the object_browser widget loosing the mode and return props which got the default "multiple", "multiple" values even when "image", "single" was desired. As a consequence this broke the preview images.
robgietema
force-pushed
the
volto-form-block-fixes
branch
from
dd5a050 to
dc2c6a4
Compare
stevepiercy
requested changes
Dec 21, 2024
| Add taken slugs to slugify helper. @robgietema | ||
| Add filter choices, additional choices and sort to select widget. @robgietema | ||
| Add max size and accept type checks to file widget. @robgietema | ||
| Fix bug with pressing enter in blocks form. @robgietema |
| Add filter choices, additional choices and sort to select widget. @robgietema | ||
| Add max size and accept type checks to file widget. @robgietema | ||
| Fix bug with pressing enter in blocks form. @robgietema | ||
| Add option to pass custom widget config to field component. @robgietema |
There was a problem hiding this comment.
Suggested change
| Add option to pass custom widget config to field component. @robgietema | |
| Add option to pass custom widget `config` to field component. @robgietema |
| Add max size and accept type checks to file widget. @robgietema | ||
| Fix bug with pressing enter in blocks form. @robgietema | ||
| Add option to pass custom widget config to field component. @robgietema | ||
| Add optional widgets config to form component. @robgietema |
There was a problem hiding this comment.
Suggested change
| Add optional widgets config to form component. @robgietema | |
| Add optional widgets `config` to form component. @robgietema |
| import PropTypes from 'prop-types'; | ||
| import { connect } from 'react-redux'; | ||
| import { compose } from 'redux'; | ||
| import { filter, includes, map, without } from 'lodash'; |
There was a problem hiding this comment.
I recall that we want to remove lodash and use either plain JavaScript or lodash-es instead. See the PLIP at #6350.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #