Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clean make command #6403

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Fix clean make command #6403

merged 2 commits into from
Oct 14, 2024

Conversation

sneridagh
Copy link
Member

@sneridagh sneridagh commented Oct 14, 2024

Closes #6403


@sneridagh sneridagh requested a review from fredvd October 14, 2024 11:04
Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 54c8d79
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/670cfb00f42d84000844736c

@sneridagh sneridagh linked an issue Oct 14, 2024 that may be closed by this pull request
@fredvd
Copy link
Member

fredvd commented Oct 14, 2024

copied from PR:

Tested locally with the branch: the files are now kept.

When running make, it still shows warnings that it cannot find node_modules with the find, which is strange and exits with an error code . Running make clean a second time and the clean finishes ok.

Another thing while testing the issue with make clean. When I do a clean checkout from the the plone/volto repo and do a make install, is it normal that the pnpm-lock.yaml be changed right away compared to git? I updated to the latest pnpm . AFAIK KGS is KGS, or can this happen anytime with pnpm that is finds newer minor versions within the ranges specified for packages?

Studio1:volto fred$ make clean
find: ./packages/blocks/node_modules: No such file or directory
find: ./packages/generator-volto/node_modules: No such file or directory
find: ./packages/types/node_modules: No such file or directory
find: ./packages/volto-slate/node_modules: No such file or directory
find: ./packages/coresandbox/node_modules: No such file or directory
find: ./packages/providers/node_modules: No such file or directory
find: ./packages/volto-testing/node_modules: No such file or directory
find: ./packages/volto/node_modules: No such file or directory
find: ./packages/components/node_modules: No such file or directory
find: ./packages/scripts/node_modules: No such file or directory
find: ./packages/registry/node_modules: No such file or directory
find: ./packages/slots/node_modules: No such file or directory
find: ./packages/client/node_modules: No such file or directory
find: ./packages/helpers/node_modules: No such file or directory
make: *** [clean] Error 1
Studio1:volto fred$ make clean

pnpm-lock.yaml changes:

git-diff-output.log

Copy link
Member

@fredvd fredvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but some extra questions on current main status and pnpm-lock.yml

@sneridagh
Copy link
Member Author

@fredvd I haven't tried the command, but I tried the find and it did work, no clue why it's complaining.

Regarding the pnpm changes, sometimes if someone changes the metadata of a package during a minor, etc, the lock changes. However, it's only metadata too.

Remember to install pnpm always using corepack, no local manual installation.

@sneridagh sneridagh merged commit a74ec0c into main Oct 14, 2024
70 checks passed
@sneridagh sneridagh deleted the fixmakeclean branch October 14, 2024 14:11
sneridagh added a commit that referenced this pull request Oct 14, 2024
* main: (185 commits)
  Release @plone/components 2.0.0-alpha.15
  [components] Fix Select component logic to support `items` use case (#6405)
  Fix clean make command (#6403)
  Release 18.0.0-alpha.46
  Release @plone/components 2.0.0-alpha.14
  Add missing export for new components (#6391)
  Revert "Fix block chooser search is not focusable when clicked on add button" (#6390)
  Replace unhelpful words with helpful ones (#6386)
  Added missing improvement to the build-deps Makefile command (#6383)
  Added rule for ESlint to detect missing key property in iterators. (#6387)
  Fix syntax of `html_meta` under `myst` field. (#6385)
  Release 18.0.0-alpha.45
  Release @plone/components 2.0.0-alpha.13
  Release @plone/types 1.0.0-alpha.20
  Add chapter: theming a base theme (#6328)
  Upgrade vite to latest (#6373)
  Porting a few minor fixes upstream (#6382)
  Added missing arg for `buildStyleClassNamesExtenders` (#6381)
  Remove pin on Vale, and upgrade to v3.x configuration (#6376)
  Change formatting from blob of text to definition list. (#6378)
  ...
sneridagh added a commit that referenced this pull request Oct 18, 2024
* main:
  Release generate-volto 9.0.0-alpha.19
  Release @plone/providers 1.0.0-alpha.3
  Release @plone/components 2.0.0-alpha.16
  Release @plone/client 1.0.0-alpha.19
  Release @plone/types 1.0.0-alpha.21
  Some types improvements/fixes (#6412)
  [providers] Improve and group providers (#6069)
  Adjust the path to perform a proper `git diff` between the cached and… (#6410)
  Test whether commenting out the `ignore` command has any affect on the Netlify build.
  support depth in getNavigationQuery (#6400)
  Update caniuse Oct24 (#6408)
  Upgraded nextjs deps and configuration (#6388)
  Update `typescript` and `vitest` everywhere (#6407)
  Remove all traces of Jest 24 in core (#6406)
  Release @plone/components 2.0.0-alpha.15
  [components] Fix Select component logic to support `items` use case (#6405)
  Fix clean make command (#6403)
sneridagh added a commit that referenced this pull request Oct 18, 2024
sneridagh added a commit that referenced this pull request Oct 18, 2024
* main: (37 commits)
  Release generate-volto 9.0.0-alpha.19
  Release @plone/providers 1.0.0-alpha.3
  Release @plone/components 2.0.0-alpha.16
  Release @plone/client 1.0.0-alpha.19
  Release @plone/types 1.0.0-alpha.21
  Some types improvements/fixes (#6412)
  [providers] Improve and group providers (#6069)
  Adjust the path to perform a proper `git diff` between the cached and… (#6410)
  Test whether commenting out the `ignore` command has any affect on the Netlify build.
  support depth in getNavigationQuery (#6400)
  Update caniuse Oct24 (#6408)
  Upgraded nextjs deps and configuration (#6388)
  Update `typescript` and `vitest` everywhere (#6407)
  Remove all traces of Jest 24 in core (#6406)
  Release @plone/components 2.0.0-alpha.15
  [components] Fix Select component logic to support `items` use case (#6405)
  Fix clean make command (#6403)
  Release 18.0.0-alpha.46
  Release @plone/components 2.0.0-alpha.14
  Add missing export for new components (#6391)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'make clean' removes checked in files from the repo
2 participants