-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clean make command #6403
Fix clean make command #6403
Conversation
✅ Deploy Preview for plone-components canceled.
|
copied from PR: Tested locally with the branch: the files are now kept. When running make, it still shows warnings that it cannot find node_modules with the find, which is strange and exits with an error code . Running make clean a second time and the clean finishes ok. Another thing while testing the issue with
pnpm-lock.yaml changes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but some extra questions on current main status and pnpm-lock.yml
@fredvd I haven't tried the command, but I tried the Regarding the pnpm changes, sometimes if someone changes the metadata of a package during a minor, etc, the lock changes. However, it's only metadata too. Remember to install pnpm always using corepack, no local manual installation. |
* main: (185 commits) Release @plone/components 2.0.0-alpha.15 [components] Fix Select component logic to support `items` use case (#6405) Fix clean make command (#6403) Release 18.0.0-alpha.46 Release @plone/components 2.0.0-alpha.14 Add missing export for new components (#6391) Revert "Fix block chooser search is not focusable when clicked on add button" (#6390) Replace unhelpful words with helpful ones (#6386) Added missing improvement to the build-deps Makefile command (#6383) Added rule for ESlint to detect missing key property in iterators. (#6387) Fix syntax of `html_meta` under `myst` field. (#6385) Release 18.0.0-alpha.45 Release @plone/components 2.0.0-alpha.13 Release @plone/types 1.0.0-alpha.20 Add chapter: theming a base theme (#6328) Upgrade vite to latest (#6373) Porting a few minor fixes upstream (#6382) Added missing arg for `buildStyleClassNamesExtenders` (#6381) Remove pin on Vale, and upgrade to v3.x configuration (#6376) Change formatting from blob of text to definition list. (#6378) ...
* main: Release generate-volto 9.0.0-alpha.19 Release @plone/providers 1.0.0-alpha.3 Release @plone/components 2.0.0-alpha.16 Release @plone/client 1.0.0-alpha.19 Release @plone/types 1.0.0-alpha.21 Some types improvements/fixes (#6412) [providers] Improve and group providers (#6069) Adjust the path to perform a proper `git diff` between the cached and… (#6410) Test whether commenting out the `ignore` command has any affect on the Netlify build. support depth in getNavigationQuery (#6400) Update caniuse Oct24 (#6408) Upgraded nextjs deps and configuration (#6388) Update `typescript` and `vitest` everywhere (#6407) Remove all traces of Jest 24 in core (#6406) Release @plone/components 2.0.0-alpha.15 [components] Fix Select component logic to support `items` use case (#6405) Fix clean make command (#6403)
* main: (37 commits) Release generate-volto 9.0.0-alpha.19 Release @plone/providers 1.0.0-alpha.3 Release @plone/components 2.0.0-alpha.16 Release @plone/client 1.0.0-alpha.19 Release @plone/types 1.0.0-alpha.21 Some types improvements/fixes (#6412) [providers] Improve and group providers (#6069) Adjust the path to perform a proper `git diff` between the cached and… (#6410) Test whether commenting out the `ignore` command has any affect on the Netlify build. support depth in getNavigationQuery (#6400) Update caniuse Oct24 (#6408) Upgraded nextjs deps and configuration (#6388) Update `typescript` and `vitest` everywhere (#6407) Remove all traces of Jest 24 in core (#6406) Release @plone/components 2.0.0-alpha.15 [components] Fix Select component logic to support `items` use case (#6405) Fix clean make command (#6403) Release 18.0.0-alpha.46 Release @plone/components 2.0.0-alpha.14 Add missing export for new components (#6391) ...
Closes #6403