-
-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass intl object to initialValue function #6538
Conversation
✅ Deploy Preview for plone-components canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but needs a technical review from the @plone/volto-team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is nonbreaking even if some of these files are customized, because it'll keep the old behavior where intl is missing if it isn't passed somewhere, and javascript doesn't complain about extra arguments. But it would be nice to get a second opinion from someone else too.
@davisagli I agree with you. This doesn't break anything. @sneridagh, can you take a look please? |
6ac6183
to
f2e6c6f
Compare
The function that calls initialValue is applyBlockInitialValue. So all functions that call applyBlockInitialValue must receive intl.
Pass intl object to functions that internally call initialValue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can I have another review from @plone/volto-team ? Thanks!
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
The function that calls
initialValue
isapplyBlockInitialValue
. So all functions that callapplyBlockInitialValue
must receiveintl
.Closes #6529