Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass intl object to initialValue function #6538

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Pass intl object to initialValue function #6538

merged 3 commits into from
Jan 31, 2025

Conversation

wesleybl
Copy link
Member

@wesleybl wesleybl commented Dec 13, 2024


If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

The function that calls initialValue is applyBlockInitialValue. So all functions that call applyBlockInitialValue must receive intl.

Closes #6529

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit f2e6c6f
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/67991aa6a0419f00084f33f9

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs a technical review from the @plone/volto-team

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is nonbreaking even if some of these files are customized, because it'll keep the old behavior where intl is missing if it isn't passed somewhere, and javascript doesn't complain about extra arguments. But it would be nice to get a second opinion from someone else too.

@wesleybl
Copy link
Member Author

I think this is nonbreaking even if some of these files are customized, because it'll keep the old behavior where intl is missing if it isn't passed somewhere, and javascript doesn't complain about extra arguments. But it would be nice to get a second opinion from someone else too.

@davisagli I agree with you. This doesn't break anything.

@sneridagh, can you take a look please?

The function that calls initialValue is applyBlockInitialValue. So all
functions that call applyBlockInitialValue must receive intl.
Pass intl object to functions that internally call initialValue
Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can I have another review from @plone/volto-team ? Thanks!

@davisagli davisagli merged commit afcb3cf into main Jan 31, 2025
77 checks passed
@davisagli davisagli deleted the initialvalue_intl branch January 31, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

intl is not passed to the initialValue function
4 participants