Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhanced undo ctrl panel #6545

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Conversation

giuliaghisini
Copy link
Contributor

@giuliaghisini giuliaghisini commented Dec 17, 2024

Enhanced Undo controlpanel.

Now it displays a loader while waiting for transactions from Plone.
When you want to delete some transaction, a confirm popup asks the user to confirm undo action for selected items.
Changed columns width to better display path.
Added select-all.
Added pagination.
Added OP column.
Added some translations.

Registrazione.schermo.2024-12-19.alle.12.43.49.mov

Is it possibile to cherry-pick this PR in 17.x.x ?

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 5cadfd1
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/676406afbd7cbe0008302370

@stevepiercy
Copy link
Collaborator

For accessibility, the issue of standardizing colors came up in:

The topic was added as an item to the PLIP.

@stevepiercy stevepiercy requested a review from a team December 18, 2024 12:20
@giuliaghisini
Copy link
Contributor Author

For accessibility, the issue of standardizing colors came up in:

The topic was added as an item to the PLIP.

ok, ill'remove this fixes

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly comments on the .pot file to apply throughout the .po files, and expand the change log entry.

packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/news/6545.feature Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Collaborator

ok, ill'remove this fixes

I think it's OK to leave them in, so we can see what you came up with and discuss it. I did not mean for you to delete them. Sorry for the miscommunication.

giuliaghisini and others added 13 commits December 18, 2024 16:22
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@giuliaghisini
Copy link
Contributor Author

ok, ill'remove this fixes

I think it's OK to leave them in, so we can see what you came up with and discuss it. I did not mean for you to delete them. Sorry for the miscommunication.

don't worry. I prefered to remove that styles because out of this pr. It's better to manage a11y styles in a single consistent pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants