Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added swedish translation #6557

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Conversation

TechSubham
Copy link
Member

@TechSubham TechSubham commented Dec 25, 2024

  • [ ✅] I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • [ ✅] I verified there aren't other open pull requests for the same change.
  • [ ✅] I followed the guidelines in Contributing to Volto.
  • [ ✅] I succesfully ran code linting checks on my changes locally.
  • [ ✅] I succesfully ran unit tests on my changes locally.
  • [ ✅] I succesfully ran acceptance tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes, either in the Storybook or narrative documentation.
  • [ ✅ ] I included a change log entry in my commits.

Closes #5957

Copy link

netlify bot commented Dec 25, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 9d323dd
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/676cfe28c441f1000831ec51

@TechSubham
Copy link
Member Author

I have passed all the tests , i request someone to review the changes

@sneridagh sneridagh merged commit e55b4a6 into plone:main Jan 8, 2025
44 checks passed
sneridagh added a commit that referenced this pull request Jan 10, 2025
* main:
  Slate Italian translations (#6563)
  Release 18.5.0
  Fix robots.txt in devmode (#6571)
  added swedish translation (#6557)
  Depth search issue (#6558)
  Block examples documentation (#6560)
  Fixed folder contents issues with persistent selection (#6554)
  Fix redirects to MDN responsive images (#6552)
  Bugfix remove query string inclusion in body class generation logic (#6547)
  Show related items (#4381)
  Update links to kitconcept.com
  Release 18.4.0
  Release @plone/components 3.0.1
  Release @plone/types 1.2.0
  Fix precedence of the quanta layer by adding a base layer for all the… (#6539)
  Add monorepo structure to the README (#6542)
@AndreasJonsson
Copy link

@TechSubham Du comittade min översättning, vilket är upphovrättsbrott och dessutom bryter mot avtalet du just skrivit under för Plone Foundation. Vem är du och vad håller du på med?

sneridagh added a commit that referenced this pull request Jan 10, 2025
@sneridagh
Copy link
Member

Reverting this PR, under the suspicion that this PR was a copy of the #5957
reported by @AndreasJonsson on 10/01/25. We will open an investigation to clarify the details.

@stevepiercy
Copy link
Collaborator

If I had triaged this one, I would have rejected it based on the change log entry. We can't accept MyST markup in change logs because it renders badly at https://github.com/plone/volto/blob/main/packages/volto/CHANGELOG.md, even though this file eventually gets copied into the docs directory.

@sneridagh we also need to replace this changelog entry at https://github.com/plone/volto/blame/main/packages/volto/CHANGELOG.md#L25, giving proper credit where it is due. I would prefer to obliterate the incorrect credit, but I don't know whether that also involves a yank and re-release. What a hassle!

@TechSubham
Copy link
Member Author

@AndreasJonsson Myself Subham and I am an undergraduate student currently in my second year at NSUT, India. I have not copied your code; however adding this feature is a two-to-three-step process that is the same for all users.

Regarding the translation, I am not proficient in Swedish. Therefore, I utilized AI tools to translate the text. I have not reviewed your translations, so I cannot confirm if it is all same .

@stevepiercy I will update the changelog entry as I am a new contributor to Open Source and this is my second pull request. I did not realize that I was not following the documentation you mentioned. I had read the documentation, but I wrote this entry after reading it. I believed that my entry was correct.

I apologize for the inconvenience caused.

@stevepiercy
Copy link
Collaborator

Reverting this PR, under the suspicion that this PR was a copy of the #5957 reported by @AndreasJonsson on 10/01/25. We will open an investigation to clarify the details.

That's the original issue number. Here's the link to the PR that we had to close due to no response from @AndreasJonsson after multiple requests:

@AndreasJonsson
Copy link

@AndreasJonsson Myself Subham and I am an undergraduate student currently in my second year at NSUT, India. I have not copied your code; however adding this feature is a two-to-three-step process that is the same for all users.

You did copy the translation.

Regarding the translation, I am not proficient in Swedish. Therefore, I utilized AI tools to translate the text. I have not reviewed your translations, so I cannot confirm if it is all same .

Its identical and it is not generated by AI tools.

@TechSubham
Copy link
Member Author

TechSubham commented Jan 11, 2025

Screenshot 2025-01-11 at 7 29 39 AM

@AndreasJonsson
as you can see i already have 2 closed pr regarding this enchancement bcz there were some errors in the AI generated translations so it took me almost 7 days to translate it and i didn't know about the translations that you made

I just want to convey that this is not done purposefully , it just a coincidence if you want i will delete this branch and close this pr also bcz i didn't want to drag this issue any longer as i want to work with you guys 🙂

@stevepiercy
Copy link
Collaborator

Dear @AndreasJonsson @TechSubham, we take allegations of potential misconduct very seriously. The Volto Team started an investigation into this matter. This will take time. We may contact you privately to get more information. Would you both please refrain from making public comments on this matter until we complete a full investigation? Thank you for your collaboration, patience, and consideration. We appreciate it.

@plone plone locked as too heated and limited conversation to collaborators Jan 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Swedish translation
4 participants