Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes race condition #15

Merged
merged 3 commits into from
Aug 29, 2022
Merged

fixes race condition #15

merged 3 commits into from
Aug 29, 2022

Conversation

edublancas
Copy link
Contributor

closes #12

I wanted to replicate the issue and ended up writing a test, then tried @yafimvo's proposed solution and it works.

@edublancas edublancas requested a review from yafimvo August 28, 2022 21:14
yafimvo
yafimvo reviewed Aug 29, 2022
View reviewed changes
Copy link
Collaborator

@yafimvo yafimvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally.
lgtm

@edublancas edublancas merged commit e6e5cc3 into main Aug 29, 2022
@edublancas edublancas deleted the race-condition branch August 29, 2022 13:37
@edublancas edublancas mentioned this pull request Nov 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yafimvo yafimvo yafimvo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

config fails to initialize
2 participants
@edublancas @yafimvo