Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI speed #734

Merged
merged 3 commits into from
Jul 16, 2023
Merged

fix CI speed #734

merged 3 commits into from
Jul 16, 2023

Conversation

edublancas
Copy link

@edublancas edublancas commented Jul 14, 2023

Describe your changes

This PR speeds up the CI, it was slowing down a lot because of a problem in ploomber-core

you can see it here:

before: https://github.com/ploomber/jupysql/actions/runs/5546740202/jobs/10127439854
after: https://github.com/ploomber/jupysql/actions/runs/5558949460/jobs/10154574710

i.e., Python 3.11 ubuntu went from 25mins to 6.5 mins! (on windows the performance increased even more)

(opened ploomber/core#70 to investigate the root cause)

Issue number

Closes #X

Checklist before requesting a review


📚 Documentation preview 📚: https://jupysql--734.org.readthedocs.build/en/734/

@edublancas edublancas added allow-workflow-edits Allow edits to .github/workflows no-changelog This PR doesn't require a changelog entry labels Jul 14, 2023
@edublancas edublancas marked this pull request as ready for review July 14, 2023 23:10
@edublancas edublancas requested a review from yafimvo as a code owner July 14, 2023 23:10
@edublancas edublancas requested a review from neelasha23 July 14, 2023 23:10
@neelasha23
Copy link

Do you think it would help if we document these CI fix changes in the developer docs? There was one related to upload docs build cache to S3, and this one also. Might be easy for reference @edublancas

@edublancas
Copy link
Author

for this one, it'll be better to just fix the core problem, that's why I opened ploomber/core#70 this is a temp fix

Copy link

@yafimvo yafimvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@edublancas edublancas merged commit f467202 into master Jul 16, 2023
@edublancas edublancas deleted the ci-speed branch July 16, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allow-workflow-edits Allow edits to .github/workflows no-changelog This PR doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants