Skip to content
This repository has been archived by the owner on Apr 26, 2022. It is now read-only.

Adds types for comments in actions array #149

Merged
merged 2 commits into from
Feb 18, 2020
Merged

Adds types for comments in actions array #149

merged 2 commits into from
Feb 18, 2020

Conversation

zonzujiro
Copy link
Contributor

@zonzujiro zonzujiro commented Feb 18, 2020 •
edited
Loading

Roses are red,
Violets are blue,
JS version use comments, TS - you should too

@crutchcorn
Copy link
Member

Rhyming is fun. I know that I do
But the more I think about it, it should be a Haiku

@crutchcorn crutchcorn merged commit b22a7ed into plopjs:master Feb 18, 2020
@zonzujiro zonzujiro deleted the fix/types-for-comments-in-actions branch February 19, 2020 08:46
@zonzujiro
Copy link
Contributor Author

@crutchcorn do you have info when fix will be released? Because it is not only about comments.
Custom actions should return string :)

@tuliren tuliren mentioned this pull request Oct 24, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crutchcorn crutchcorn Awaiting requested review from crutchcorn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zonzujiro @crutchcorn