Adding Typescript support #431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prisis
commented
Apr 12, 2024
|
Hey @prisis - sorry for not making this clearer sooner. There's a lot of edgecases with TypeScript support that has us concerned with merging any PR like this, including my own that I made. Instead, we're opting (for now) to go with a docs solution to the problem ala #428. As a result, I'm going to close this issue. Huge apologies for the miscommunication on my part |
|
Could you describe some of the edgecases or in with ticket can i find it? |
|
These were some of the edgecases: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a bit of time :D
This MR follow a different approach, Typescript support out of the box with jiti, with this merge, plop will support
Closes:
#297
#397
#426
#427
#428
#416
Thanks to @benallfree for the command and docs