Mutiple oauth app urls #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the previous implementation of `wait_for` wasn’t very reliable. I switched it out in a separate dash repo in the fall, now copying those changes over here.
they are misconfigured for some reason and not super necessary for this test suite anyway
`self.driver.get(…)` is now blocking if the page has a basic auth screen and it takes a long time to error out. this wasn’t the case with the old chromedriver.
|
@cldougl @scjody - Ready for review. Related to https://github.com/plotly/dash-on-premise-sample-app/pull/13. This PR allows multiple oauth URLs to be used, enabling users to add plotly login screens to their apps running on |
scjody
approved these changes
Mar 26, 2018
CHANGELOG.md
Outdated
| the login screen available in your deployed app. Usage: | ||
| ``` | ||
| dash_auth.PlotlyAuth(app, 'my-app', 'private', [ | ||
| 'http://localhost:8050', |
There was a problem hiding this comment.
It looks like the "main" app URL should be first. I'd call this out in your docs and fix this example.
| on the Plotly server | ||
| sharing: 'private' or 'public' | ||
| app_url: String or list of strings. The URL(s) of the Dash app. | ||
| This is used to register your app with Plotly's OAuth system. |
There was a problem hiding this comment.
Again, the "main" URL goes first.
|
Also please make sure you've tested all the code paths on an actual On-Prem server. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/plotly/dash-on-premise-sample-app/pull/13