npm run scripts: wait for the spawned process to finish #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
&
causes the command to be run in the background. whereas&&
waits for the command to exit successfully.As far as I can tell, it could have been intended to use
&
. If that's the cause usingwait
might be beneficial as (1) it shows the clear intention of running programs in parallel to the reader and (2) the CLI actually waits for the processes to finish and not suddenly dumps texts after a few seconds.Though I'm not sure whether
wait
will work on Windows.A better alternative might be concurrently.
See also: