Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Markdown & SyntaxHighlighter children prop should accept an array of strings  #134

Closed
@cpsievert

Description

@cpsievert

Providing one long string is susceptible to unintended consequences from indentation rules (e.g. markdown interpreting 4 spaces as a code block). Being able to provide an array of strings would help avoid that problem somewhat.

Seems like we could just do children.join('\n') when children is an array?

@chriddyp happy to submit a PR if you think this is worthwhile (not sure how to set propTypes so that both an array and a string would be acceptable).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions