Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Markdown & SyntaxHighlighter children prop should accept an array of strings #134

Closed
cpsievert opened this issue Jan 2, 2018 · 1 comment

Comments

@cpsievert
Copy link
Contributor

Providing one long string is susceptible to unintended consequences from indentation rules (e.g. markdown interpreting 4 spaces as a code block). Being able to provide an array of strings would help avoid that problem somewhat.

Seems like we could just do children.join('\n') when children is an array?

@chriddyp happy to submit a PR if you think this is worthwhile (not sure how to set propTypes so that both an array and a string would be acceptable).

@chriddyp
Copy link
Member

chriddyp commented Jan 2, 2018

yeah, that's a good idea. sure, I'll accept a PR on this. See https://reactjs.org/docs/typechecking-with-proptypes.html for more on proptypes. PropTypes.oneOfType([PropTypes.string, PropTypes.arrayOf(PropTypes.string)]) should work here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants