This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 145
Update requirements to support React 16 #165
Closed
Closed
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
e99bff2
Update babel to use style and css loaders for react-dates. Use new st…
mjclawar 69415ba
Add back Dropdown and update package.json to remove unnecessary babel…
mjclawar f2f65d4
Remove additional react-virtualized requirement in favor of old, only…
mjclawar e02208c
v0.20.0
mjclawar 61207be
0.20.0
mjclawar 4a93f26
Merge remote-tracking branch 'upstream/master' into 164-react-16
mjclawar 697a9a5
Merge remote-tracking branch 'upstream/master' into 164-react-16
mjclawar 55adf46
Update tests for non dash-table-experiments to use React v16.2.
mjclawar c365c6a
Fix typing issue from colon to =
mjclawar 4bca18b
Update requirements-locked for dash-renderer
mjclawar 6a7a38b
Update requirements-locked to newer dash and dash-html-components, re…
mjclawar 09ead14
- Remove css-loader package.json requirement
mjclawar 47eb34c
Update versions in dash_core_components.__init__ for css
mjclawar e9976e8
- Update to v1.0.0 for breaking CSS changes
mjclawar be35156
1.0.0
mjclawar 738c854
Merge remote-tracking branch 'upstream/master' into 164-react-16
mjclawar 4bcf2f8
Update .github for PR and issue templates
mjclawar fb9c27b
Merge remote-tracking branch 'upstream/master' into 164-react-16
mjclawar 8001b95
Update from master
mjclawar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
<!--- Thanks for starting to open an issue for dash-core-components! We appreciate you being a part of the community. --> | ||
<!--- Note that for general help questions, https://community.plot.ly/c/dash is probably your best bet! ---> | ||
<!--- You can help make the development process better by taking some time to write a complete description of the bug or feature request. --> | ||
<!--- Below, provide a general summary of your changes in the Title above --> | ||
|
||
<!--- Please fill out a description, even if you are reporting a simple issue. If it is something truly simple, it is okay to keep it short and sweet. --> | ||
## Description | ||
<!--- A clear and concise description of what the issue is about. Include things like expected/desired behavior, actual behavior, motivation or rationale for a new feature, what files it concerns, etc. --> | ||
|
||
## Sub-tasks | ||
<!--- If you suspect that this issue has multiple steps to get the job done, list them out as markdown checkboxes. --> | ||
<!--- If not, feel free to delete this section. --> | ||
- [ ] Task 1 | ||
- [ ] Task 2 | ||
- [ ] Task 3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
<!--- Provide a general summary of your changes in the Title above --> | ||
|
||
<!--- Fill out a description and motivation. If it is something truly simple, it is okay to keep it short and sweet. --> | ||
## Description | ||
<!--- Describe your changes in detail and link to the issue that is driving this pull request (if any). The description here should describe what features were added, or addressing a bug and describing what was fixed.--> | ||
|
||
<!--- Did you run the test suite locally? Did you add any tests for new behavior? --> | ||
- [ ] `dash_core_components/version.py` has been updated if necessary | ||
- [ ] `package.json` has been versioned if necessary | ||
- [ ] `CHANGELOG.md` has a detailed new entry if necessary | ||
- [ ] `MANIFEST.in` has been updated if non-Python files were updated in dash_core_components | ||
- [ ] [Tests pass](https://github.com/plotly/dash-core-components/blob/master/.github/CONTRIBUTING.md#running-the-tests) on my local machine | ||
|
||
## What does this address? | ||
<!--- What bug does this fix? What issues does this close? --> | ||
Closes # |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
include dash_core_components/bundle.js | ||
include dash_core_components/bundle.js.map | ||
include dash_core_components/metadata.json | ||
include dash_core_components/rc-slider@6.1.2.css | ||
include dash_core_components/react-select@1.0.0-rc.3.min.css | ||
include dash_core_components/rc-slider@8.6.0.css | ||
include dash_core_components/react-select@1.2.1.min.css | ||
include dash_core_components/plotly-1.35.2.min.js | ||
include dash_core_components/react-virtualized-select@3.1.0.css | ||
include dash_core_components/react-virtualized@9.9.0.css | ||
include dash_core_components/react-dates@12.3.0.css | ||
include dash_core_components/react-virtualized-select@3.1.3.css | ||
include dash_core_components/react-virtualized@9.18.5.css | ||
include dash_core_components/react-dates_datepicker@16.3.2.min.css | ||
include README.md | ||
include LICENSE.md |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,8 @@ | |
padding: 5px 0; | ||
width: 100%; | ||
border-radius: 6px; | ||
-ms-touch-action: none; | ||
touch-action: none; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, very nice - we have the diffs in here |
||
box-sizing: border-box; | ||
-webkit-tap-highlight-color: rgba(0, 0, 0, 0); | ||
} | ||
|
@@ -16,6 +18,7 @@ | |
width: 100%; | ||
background-color: #e9e9e9; | ||
height: 4px; | ||
border-radius: 6px; | ||
} | ||
.rc-slider-track { | ||
position: absolute; | ||
|
@@ -31,16 +34,27 @@ | |
width: 14px; | ||
height: 14px; | ||
cursor: pointer; | ||
cursor: -webkit-grab; | ||
cursor: grab; | ||
border-radius: 50%; | ||
border: solid 2px #96dbfa; | ||
background-color: #fff; | ||
-ms-touch-action: pan-x; | ||
touch-action: pan-x; | ||
} | ||
.rc-slider-handle:hover { | ||
border-color: #57c5f7; | ||
} | ||
.rc-slider-handle-active:active { | ||
.rc-slider-handle:active { | ||
border-color: #57c5f7; | ||
box-shadow: 0 0 5px #57c5f7; | ||
cursor: -webkit-grabbing; | ||
cursor: grabbing; | ||
} | ||
.rc-slider-handle:focus { | ||
border-color: #57c5f7; | ||
box-shadow: 0 0 0 5px #96dbfa; | ||
outline: none; | ||
} | ||
.rc-slider-mark { | ||
position: absolute; | ||
|
@@ -78,12 +92,6 @@ | |
border-radius: 50%; | ||
vertical-align: middle; | ||
} | ||
.rc-slider-dot:first-child { | ||
margin-left: -4px; | ||
} | ||
.rc-slider-dot:last-child { | ||
margin-left: -4px; | ||
} | ||
.rc-slider-dot-active { | ||
border-color: #96dbfa; | ||
} | ||
|
@@ -96,6 +104,7 @@ | |
.rc-slider-disabled .rc-slider-handle, | ||
.rc-slider-disabled .rc-slider-dot { | ||
border-color: #ccc; | ||
box-shadow: none; | ||
background-color: #fff; | ||
cursor: not-allowed; | ||
} | ||
|
@@ -120,6 +129,8 @@ | |
.rc-slider-vertical .rc-slider-handle { | ||
margin-left: -5px; | ||
margin-bottom: -7px; | ||
-ms-touch-action: pan-y; | ||
touch-action: pan-y; | ||
} | ||
.rc-slider-vertical .rc-slider-mark { | ||
top: 0; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're bumping major versions in these libraries, I bet that this will introduce some breaking changes in the component's CSS. In case any users are overriding this CSS, then their overrides won't work anymore. So, I think we should make a breaking change version bump to
1.0.0
(according to semver)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And let's leave a note in the changelog that mentions that CSS stylesheets may be different
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't actually looked into whether or not the CSS or markup has changed in these versions, I'm just guessing that it has.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, will update to
1.0.0
.