This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Fix display of ConfirmDialogProvider if not used in a callback. #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpostlethwaite
suggested changes
Jul 23, 2018
| this.state = { | ||
| displayed: props.displayed | ||
| }; | ||
| this._setStateAndProps = this._setStateAndProps.bind(this); |
There was a problem hiding this comment.
I don't see _setStateAndProps being passed as a callback anywhere so this .bind() isn't necessary?
| }; | ||
| this._setStateAndProps = this._setStateAndProps.bind(this); | ||
| this._update = this._update.bind(this); | ||
| // this._update(); |
T4rk1n
force-pushed
the
confirm-dialog-state
branch
from
9015d91
to
a6b0278
Compare
|
@T4rk1n are you planning on adding tests to this one as per @bpostlethwaite 's recommendation? Or are confirm dialog tests too hard to add with selenium? Also, does this fix #242? This PR is blocking the documentation https://github.com/plotly/dash-docs/pull/123, so it'd be good to get it in soon 😺 |
|
💃 thanks! |
T4rk1n
force-pushed
the
confirm-dialog-state
branch
from
0f96813
to
1c9fd82
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #242.