Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Add .map files to manifest. #413

Merged
merged 2 commits into from
Dec 11, 2018
Merged

Add .map files to manifest. #413

merged 2 commits into from
Dec 11, 2018

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Dec 10, 2018

The map files were not included in the python build.

cc @Marc-Andre-Rivet @valentijnnieman

Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Checked and I didn't forget to add those on the table and on the renderer :)

include dash_core_components/dash_core_components.dev.js
include dash_core_components/dash_core_components.dev.js.map
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😺

@T4rk1n T4rk1n merged commit f18a20f into master Dec 11, 2018
@T4rk1n T4rk1n deleted the fix-map branch December 11, 2018 01:17
@Alexfinkelshtein
Copy link

I'm getting the following:
127.0.0.1 - - [18/Dec/2018 17:51:46] "GET /_dash-component-suites/dash_core_components/dash_core_components.dev.js.map?v=0.40.4&m=1545148181 HTTP/1.1" 500 -
Traceback (most recent call last):
since this version can you explain what am I missing?

@Marc-Andre-Rivet
Copy link
Contributor

@Alexfinkelshtein Please open an issue or use the community forum when encountering issues in the future. We do not usually watch out for comments on closed PRs. The likely culprit is that your dash package needs to be updated to >=0.32 for the map files to be exposed by the server.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants