-
-
Notifications
You must be signed in to change notification settings - Fork 145
Conversation
even if some of them fail. linters included
@T4rk1n the dash-core-components/test/test_integration.py Lines 1421 to 1429 in 674fd07
is failing, seems to be due to plotly/dash#547 - can you take a look at it, see if it's just the test that needs updating or if there's a real issue with the new |
OK yeah, that was an easy fix, and after looking at it in a little more detail, that test was definitely locking down buggy behavior! |
@@ -62,6 +65,7 @@ | |||
"exec-sh": "^0.3.0", | |||
"jest": "^23.6.0", | |||
"lodash": "^4.17.11", | |||
"npm-run-all": "^4.1.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do so love this package 🥇
|
Can you confirm what version of |
Test run in dash-docs seems to be behaving fine. Once the ☝️ are fixed I'm fine with this PR. |
Right, this needs to be built off the |
"lint:py": "flake8 --ignore=E501,F401,F841,F811 test", | ||
"test": "run-s -c test-unit test:py test:pyimport lint format:test lint:py", | ||
"test:py": "python -m unittest test.test_integration", | ||
"test:pyimport": "python -m unittest test.test_dash_import", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can combine them with python -m unittest discover
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good to know! But test_dash_import
is funny, since it rewrites files (specifically, making a dash.py
in the test folder) you can't run it in conjunction with any of the other tests. So if we wanted to use discover
we'd have to make test_dash_import
undiscoverable one way or another, and still run it separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, that test is strange, not sure we really need to test that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess someone put that error message in the code, so they wanted to see it in a test. But yeah, not the most useful test to be lugging around.
Ah good call, that came in with a community PR after my initial sweep through the code... fixed in 7d82256
Sure, easy enough -> 948c7dc |
n_blur: 0, | ||
n_blur_timestamp: -1, | ||
n_clicks: 0, | ||
n_clicks_timestamp: -1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😺 This addition of props should be noted somewhere, had to read the code to see it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Maybe @T4rk1n will have additional insight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
Closes #433 - last in the series for plotly/dash#531
In addition, as in the other no-events PRs, I tried to unify the local and CI test runners, and make it so on CI all tests run, even if an earlier one fails, so you get a complete failure report - see 3f0b9df, @T4rk1n @Marc-Andre-Rivet are you comfortable with this?