Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

🐛 fix loading_state props for input #498

Merged
merged 2 commits into from
Mar 26, 2019
Merged

🐛 fix loading_state props for input #498

merged 2 commits into from
Mar 26, 2019

Conversation

byronz
Copy link
Contributor

@byronz byronz commented Mar 25, 2019

the loading_state should not be specified as props, as it already specified by data-* at top.

Marc-Andre-Rivet
Marc-Andre-Rivet approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃(build pending) I'm fine with this not having a changelog entry as the bug should only be expressed in React 16

@Marc-Andre-Rivet
Copy link
Contributor

Marc-Andre-Rivet commented Mar 25, 2019 •
edited
Loading

@byronz py37 failed on test_graphs_with_different_figures this is as in https://github.com/plotly/dash-core/issues/54 -- just rerun the tests...

@byronz byronz merged commit 6abe86c into master Mar 26, 2019
@byronz byronz deleted the fix-input-loading-state branch March 26, 2019 00:06
@Marc-Andre-Rivet Marc-Andre-Rivet mentioned this pull request Mar 26, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Marc-Andre-Rivet Marc-Andre-Rivet Marc-Andre-Rivet approved these changes

@valentijnnieman valentijnnieman Awaiting requested review from valentijnnieman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byronz @Marc-Andre-Rivet