Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

update Dropdown to accept optionHeight prop #552

Merged
merged 2 commits into from
May 10, 2019
Merged

update Dropdown to accept optionHeight prop #552

merged 2 commits into from
May 10, 2019

Conversation

mmartinsky
Copy link
Contributor

@mmartinsky mmartinsky commented May 10, 2019

Closes #544

Add the ability to set the optionHeight of the react-virtualized-select options. This is useful if you have labels that are too long to fit on a single line, but don't want the options to overlap.

New, using optionHeight={50}
image

Old/Default:
image

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmartinsky - this will be helpful. (For the sake of others reading this, I'll note that 35 is the default from the underlying component https://github.com/bvaughn/react-virtualized-select. It makes sense to list this explicitly here so people know the baseline against which to provide a different value)

@alexcjohnson alexcjohnson merged commit 0fc7e15 into plotly:master May 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants