Async components #692
Async components #692
Conversation
Marc-Andre-Rivet
requested review from
alexcjohnson and
byronz
as code owners
| } | ||
|
|
||
| componentWillMount() { | ||
| this.propsToState(this.props, true); |
There was a problem hiding this comment.
This is the most significant code change. Since the real/fragment component is wrapped, its props lifecycle is slightly different, propsToState is updated to only update the state when the value changes or if forced (on mount)
There was a problem hiding this comment.
I'm missing something - this seems like it would have been a good idea before, but somehow more than a good idea it's actually necessary now? What's the bad thing that happens if we don't do this?
There was a problem hiding this comment.
props override state, always - the component essentially doesn't work at all anymore - I haven't looked deeply into it but the wrapper addition seems to affect the lifecycle of the wrapped component. I'm unwilling to make the wrapper pure as the real component isn't.
There was a problem hiding this comment.
#692 (comment) is just for information, no change needed. This looks great. 💃
|
Will wait on #693 for the test fix as this alone will trigger an incorrect baseline b/c of November calendar 👽 |
Follow up to #616
Brings async to components:
Slider/RangeSlider behave incorrectly when asynced -- they seem to execute just fine but they display nothing. Needs to be investigated further, and there is diminishing returns.
Brings
dcc.min.jsentry point down from ~1.09MB to ~374kB.None of these components have side-effects, so they do not use the async decorator.