Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Conversation

rpkyle
Copy link
Contributor

@rpkyle rpkyle commented Dec 17, 2019

This PR proposes to update dashCoreComponents to 1.6.0, while also contributing a vignette.

This PR is related to, and required for plotly/dashR#157 to function properly.

@rpkyle rpkyle added this to the Dash v1.8 milestone Dec 17, 2019
@rpkyle rpkyle requested a review from alexcjohnson as a code owner December 17, 2019 22:02
@rpkyle rpkyle self-assigned this Dec 17, 2019
all_files = FALSE, dynamic = TRUE), class = "html_dependency"),
`dash_core_components` = structure(list(name = "dash_core_components",
version = "1.51.2", src = list(href = NULL,
version = "1.6.0", src = list(href = NULL,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to use the project version instead of the Plotly.js version here. 👍

@rpkyle rpkyle merged commit c107e0f into master Dec 19, 2019
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the 1048-async-r branch December 19, 2019 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants