This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 145
Added click modifiers, target prop #767
Merged
Merged
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c956990
Added `ctrlKey` conditional
HammadTheOne 7eab201
Added other modifiers.
HammadTheOne 78f19a5
Merge branch 'dev' into 748-control-link-fix
HammadTheOne 977cf28
Fixed formatting
HammadTheOne 0e4ac7f
Added changelog entry
HammadTheOne d5f0b38
Updated changelog message
HammadTheOne af01beb
Noise commit
HammadTheOne 1441829
Merge branch 'dev' into 748-control-link-fix
HammadTheOne ec0b49c
Added external prop
HammadTheOne 6514c83
Changed external to target
HammadTheOne ec1cae4
Change conditional for tests
HammadTheOne 7beb7d9
Fixed target prop
HammadTheOne 8434dda
Updated changelog, flaky test run
HammadTheOne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that I'd prefer that we just stick to the HTML convention here instead of defining a new API. That way, this component is more or less 1-1 with
html.A
. So, just let users pass throughtarget
directly rather than defining a newexternal
property.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen a couple of other link components define external as a separate property, but I think you raise a good point, for both maintaining parity with
html.A
and offering a bit more freedom for the user to decide what to target.Changed in 6514c83.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree @chriddyp - cc @Marc-Andre-Rivet - we had a similar discussion a couple of days ago, also because there are other values of
target
that still matter.