This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 145
Add optional numerical input box to dcc.Slider #944
Open
jdamiba
wants to merge
29
commits into
dev
Choose a base branch
from
synced-input-slider
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
c858dc9
add input that shows slider value
6aeea78
sync slider from input
d57bf70
lint
7fc4de4
fix lint errors
e24c3f5
fix lint errors
796d30d
debounce and components on same line
c5b7e51
set min width of synced input
168a99c
pass through props for synced input
2e2dbe0
let user override default styles for input
57936d4
run linter
205b9ed
set proper props for input
3168a64
refactor input state/props sync
128017b
update tests
b555515
Merge branch 'dev' into synced-input-slider
3e62912
add tests
3820ce4
lint tests
884cccb
run prettier
403ee9e
small fixups
761103c
make sure that pressing enter when input is focused changes state of …
1709c21
clear debounce timeout after every state sync
2db424b
Merge branch 'dev' into synced-input-slider
da7d116
Merge branch 'synced-input-slider' of https://github.com/plotly/dash-…
4b45284
refactor synced input event handling
b7c3154
Merge branch 'dev' into synced-input-slider
aa1ab08
Merge branch 'dev' into synced-input-slider
0111a74
camelCase to snake_case new props
02c10c6
Merge branch 'dev' into synced-input-slider
wbrgss aebce8d
add some ui ;ogic
f445f58
Merge branch 'synced-input-slider' of https://github.com/plotly/dash-…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a great test, but let's not add any more tests to the top-level files
test_integration_1
ortest_integration_2
. These use the legacyunittest
framework rather thandash.testing
. If anything we should take opportunities when we're working in neighboring code to move more tests OUT of these files and port them to usedash.testing
in the subdirectories.