This repository was archived by the owner on Jun 4, 2024. It is now read-only.
updating react and react-dom to 15.6.1 #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it's about now I guess I should probably work out how to run the tests... |
|
Oh I see that the tests have v15.4.2 hardcoded... I guess that's the likely culprit |
|
Thanks @ned2 ! It seems like this issue was temporary from unpkg: unpkg/unpkg#54 and that it is resolved. I don't think that changing the version will help us in the future here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-dom 15.4.2 seems to have disappeared from unpkg, so have upgraded external and local to 15.6.1
not sure if this is actually helpful but having got it all working on my dev environment with 15.6.1, figured I'd submit a PR