Skip to content

Add new Google Analytics tags to each app before deployment. #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 12, 2019

Conversation

shammamah-zz
Copy link
Contributor

@shammamah-zz shammamah-zz commented Nov 7, 2019

About

Addresses #343.

We are using app.index_string (https://dash.plot.ly/external-resources) to insert the scripts specified at the positions specified within the html for the page.

Since these scripts are not necessary when running the apps locally, the index_string is only specified for the deployed versions of the apps.

Handing this PR off to @ycaokris to insert the scripts according to the specifications in the issue.

@shammamah-zz shammamah-zz changed the title Add index string variable before run_server command. Add new Google Analytics tags to each app before deployment. Nov 7, 2019
@shammamah-zz shammamah-zz merged commit 2369e41 into master Nov 12, 2019
@ycaokris ycaokris mentioned this pull request Nov 12, 2019
3 tasks
shammamah-zz pushed a commit that referenced this pull request Nov 12, 2019
* remove old js git add command

* Allow Capit SERVER to pass in predeploy

* Revert "Allow Capit SERVER to pass in predeploy"

This reverts commit 17cd6c8.
@ycaokris ycaokris mentioned this pull request Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants