This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Issue 224 - Improve column id support for filtering #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 4, 2019 16:29
- clean up lexicon selector - arbitrary id test
Marc-Andre-Rivet
commented
Feb 4, 2019
| @@ -202,6 +212,8 @@ function getState() { | |||
| return getFixedVirtualizedState(); | |||
| case AppMode.ReadOnly: | |||
| return getReadonlyState(); | |||
| case AppMode.ColumnsInSpace: | |||
| return getSpaceInColumn(); | |||
There was a problem hiding this comment.
A new mock/mode with specially named columns
Marc-Andre-Rivet
commented
Feb 4, 2019
Marc-Andre-Rivet
commented
Feb 4, 2019
| @@ -55,7 +55,7 @@ export default class FilterFactory { | |||
| } | |||
|
|
|||
| setFilter(R.map( | |||
| ([cId, filter]) => `${cId} ${filter}`, | |||
| ([cId, filter]) => `"${cId}" ${filter}`, | |||
There was a problem hiding this comment.
Auto-quote the column id when generating the filter fragments from column filters
Marc-Andre-Rivet
commented
Feb 4, 2019
|
|
||
| static getFilterById(column: number | string) { | ||
| return cy.get(`#table tbody tr th.dash-filter[data-dash-column="${column}"]`); | ||
| } |
There was a problem hiding this comment.
New selectors for getting the filter cells
Marc-Andre-Rivet
commented
Feb 4, 2019
|
|
||
| DashTable.getCellById(0, 'rows').within(() => cy.get('.dash-cell-value').should('have.html', '101')); | ||
| DashTable.getCellById(1, 'rows').should('not.exist'); | ||
| }); |
There was a problem hiding this comment.
test that the filters are working fine for various special cases
Marc-Andre-Rivet
commented
Feb 4, 2019
alexcjohnson
reviewed
Feb 4, 2019
- test nested quotes - add `` to '' and "" support
alexcjohnson
reviewed
Feb 5, 2019
- add tests for badly formed operands
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #224.
Many normal usage scenarios are calling for column ids with non-word [^a-zA-Z0-9_] characters.
This PR adds the needed support for a subset of special characters [-+.:] without quotes, and for the full set of characters when single or double quoted.
Adds a few unit tests for the syntactic tree and a standalone/integration test for real-world usage validation.
Tests are passing against dash/dash-renderer latest release