Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Handle null value safely in case-insensitive filter #935

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

xwk
Copy link

@xwk xwk commented Aug 11, 2021

Fix the issue described in #934

Basically if the value is null, return empty string directly instead of call .toString()

@xwk xwk requested a review from alexcjohnson as a code owner August 11, 2021 06:47
@zekeshearer
Copy link

zekeshearer commented Mar 10, 2023

I have this same issue on dash 2.8.1. @alexcjohnson or other maintainer, could you review this?

@alexcjohnson
Copy link
Collaborator

Oh thanks @zekeshearer - I had missed this PR as this repo is obsolete. I think perhaps it was created right around when we merged Dash Table into the main Dash repo.

So we can recreate it in the Dash repo. Definitely we should fix this, but I’m not sure if empty string is the right fallback, would we be better off leaving it as its non-string value so it doesn’t match an explicit empty string?

Lastly it deserves a test case.

@bparzonz
Copy link

bparzonz commented Feb 1, 2024

Hi, this appears to still be an issue. Is it being addressed elsewhere?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants