Skip to content

Commit

Permalink
remove publish scripts & update contributing (#134)
Browse files Browse the repository at this point in the history
  • Loading branch information
Marc-Andre-Rivet committed Aug 28, 2019
1 parent 9dffc72 commit 848bed9
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 33 deletions.
1 change: 0 additions & 1 deletion packages/dash-html-components/.circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ jobs:
. venv/bin/activate
python --version
npm run clean
npm run generate-components
npm run build
- run:
Expand Down
3 changes: 3 additions & 0 deletions packages/dash-html-components/.github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# These owners will be the default owners for everything in
# the repo. Unless a later match takes precedence
* @alexcjohnson @byronz @Marc-Andre-Rivet
7 changes: 7 additions & 0 deletions packages/dash-html-components/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@ Refer to the [readme](README.md) for installation and development workflow instr

[Dash HTML Components][] consist of generic HTML5 elements based on the [MDN spec][] (also see the [W3 index of elements][]). For more complex UI components, see the [Dash Core Components][]. Contributions are welcome! This repository's open [issues][] are a good place to start.

## Making a Contribution
_For larger features, your contribution will have a higher likelihood of getting merged if you create an issue to discuss the changes that you'd like to make before you create a pull request._

1. Create a pull request.
2. After a review has been done and your changes have been approved, they will be merged and included in a future release of Dash.
3. If significant enough, you have created an issue about documenting the new feature or change and you have added it to the [dash-docs](https://github.com/plotly/dash-docs) project.

## Coding Style

Please lint any additions to react components with `npm run lint`. Rules defined in [.eslintrc](.eslintrc) are inherited from [`dash-components-archetype`](https://github.com/plotly/dash-components-archetype)'s [eslintrc-react.json][]
Expand Down
5 changes: 1 addition & 4 deletions packages/dash-html-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,9 @@
"homepage": "https://github.com/plotly/dash-html-components",
"scripts": {
"clean": "rm -rf src/* && mkdir -p src/components",
"generate-components": "cd scripts && sh generate-all.sh && cd -",
"prebuild": "cd scripts && sh generate-all.sh && cd -",
"install-local": "python setup.py install",
"uninstall-local": "pip uninstall dash-html-components -y",
"prepare": "npm run clean && npm run generate-components",
"prepublishOnly": "npm run build",
"publish-all": "node scripts/publish.js",
"lint": "eslint src scripts",
"build:js": "webpack --mode production",
"build:py_and_r": "dash-generate-components ./src/components dash_html_components -p package-info.json --r-prefix 'html'",
Expand Down
28 changes: 0 additions & 28 deletions packages/dash-html-components/scripts/publish.js

This file was deleted.

0 comments on commit 848bed9

Please sign in to comment.