-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Removing the catch all route. #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
cc @plotly/dash |
Will this break multi-page apps that rely on the I always thought this catch-all was to support this functionality, especially in the case where a user navigates directly to a page rather than manipulating the |
I see, it's probably because of that, it's a good reason to keep it then. |
Yeah, that's why we have it |
I wonder if it might be nice to at least fix the special case of the |
There is a catch all route in dash, it catch any route that doesn't exist and return a 200 with the index. I think this is bad and should be removed as it swallow errors.
dash/dash/dash.py
Lines 214 to 217 in a6388be
Example of unexpected behavior coming from this:
The browser tries to get the
/favicon.ico
from the server and dash replies OK here's the index. That means the browser will try to get the favicon everytime you load the index since it returns a 200 instead of a 404.The text was updated successfully, but these errors were encountered: