Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include development assets in Python package #810

Open
xhochy opened this issue Jul 5, 2019 · 3 comments
Open

Don't include development assets in Python package #810

xhochy opened this issue Jul 5, 2019 · 3 comments
Labels
feature something new infrastructure build process etc. P3 backlog

Comments

@xhochy
Copy link

xhochy commented Jul 5, 2019

Is your feature request related to a problem? Please describe.

The dash-renderer sdist on PyPI is quite big large (2.3M compressed, 10M uncompressed) compared to the actual required components. This is due to at least the following files that shouldn't be required:

  • dash_renderer.dev.js (3.9M)
  • dash_renderer.dev.js.map (4.5M)
  • dash_renderer.min.js.map (1.3M)

Describe the solution you'd like

Don't distribute files for development purposes in release artifacts. This would reduce the size of the package to 1/10 (200K compressed, 720K uncompressed).

Describe alternatives you've considered

As an alternative to not shipping the debug maps at all, you could also distribute them as separate -dbg packages. This would enable a user to get debug information but not having these files in all installations. This requires a lot more effort though.

@alexcjohnson alexcjohnson changed the title [Feature Request] Don't include development assest in Python package [Feature Request] Don't include development assets in Python package Jul 8, 2019
@alexcjohnson
Copy link
Collaborator

I suppose we could make the .map files optional (or not released at all, you need a full repo clone to get them) - those are really only useful for developers of dash itself. The dev bundle dash_renderer.dev.js is useful for dash app developers, so I wouldn't want to omit that. But we could minify it. Thanks for bringing this up!

@byronz
Copy link
Contributor

byronz commented Aug 28, 2019

@alexcjohnson @Marc-Andre-Rivet I think it might be a good candidate for 1.3.0, since we already have a better control on the assets with 1.2.0

@byronz
Copy link
Contributor

byronz commented Sep 9, 2019

#910 solved one part of this issue by removing completely the map files in the release process. now the compressed size is about half of the previous version.

Leave this issue open for dev bundle optimization in the future

@byronz byronz removed this from the Dash v1.4.0 milestone Sep 16, 2019
@gvwilson gvwilson added feature something new P3 backlog and removed size: 1 labels Aug 13, 2024
@gvwilson gvwilson changed the title [Feature Request] Don't include development assets in Python package Don't include development assets in Python package Aug 13, 2024
@gvwilson gvwilson added the infrastructure build process etc. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new infrastructure build process etc. P3 backlog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants