Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️ this works well without sourcemap #910

Merged
merged 5 commits into from
Sep 9, 2019
Merged

⚗️ this works well without sourcemap #910

merged 5 commits into from
Sep 9, 2019

Conversation

byronz
Copy link
Contributor

@byronz byronz commented Sep 6, 2019

#810

the final build with compressed size 1.1M and uncompressed version 5.6M

@byronz byronz marked this pull request as ready for review September 6, 2019 20:57
@byronz
Copy link
Contributor Author

byronz commented Sep 6, 2019

@alexcjohnson
after an inspiring conversation with @Marc-Andre-Rivet, I end up with a nicer solution to

  1. have two build types for webpack: release and local. the first is target to do the release process without any source map, the latter one can be used for local development and debug from the source code
  2. simplified webpack.config.js with multiple configurations https://webpack.js.org/configuration/configuration-types/#exporting-multiple-configurations

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-Authored-By: alexcjohnson <johnson.alex.c@gmail.com>
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃
Per @byronz on chat:

tried to minify [the dev build] with terse plugin, it broke the props-check feature

I would like at some point to figure this out, so we can minify the dev build as well. That would reduce the package size a good deal more. So let's leave the original issue open to investigate more later. But this is indeed a much nicer build process than before! Very nice @byronz @Marc-Andre-Rivet

@byronz byronz merged commit 6baf984 into dev Sep 9, 2019
@byronz byronz deleted the remove-map-810-1 branch September 9, 2019 17:08
@alexcjohnson alexcjohnson mentioned this pull request Oct 30, 2019
6 tasks
@alexcjohnson alexcjohnson mentioned this pull request May 27, 2021
14 tasks
HammadTheOne pushed a commit to HammadTheOne/dash that referenced this pull request May 28, 2021
HammadTheOne pushed a commit that referenced this pull request Jul 23, 2021
HammadTheOne pushed a commit that referenced this pull request Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants