-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #910 from plotly/remove-map-810-1
⚗️ this works well without sourcemap
- Loading branch information
Showing
7 changed files
with
91 additions
and
89 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| include package.json | ||
| include digest.json | ||
| include dash_renderer/*.js | ||
| include dash_renderer/*.map | ||
| exclude dash_renderer/*.map |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,87 +1,84 @@ | ||
| const webpack = require('webpack'); | ||
| const R = require('ramda'); | ||
| const path = require('path'); | ||
| const packagejson = require('./package.json'); | ||
|
|
||
| const dashLibraryName = packagejson.name.replace(/-/g, '_'); | ||
|
|
||
| module.exports = (env, argv) => { | ||
| let mode; | ||
|
|
||
| // if user specified mode flag take that value | ||
| if (argv && argv.mode) { | ||
| mode = argv.mode; | ||
| } | ||
|
|
||
| // else if configuration object is already set (module.exports) use that value | ||
| else if (module.exports && module.exports.mode) { | ||
| mode = module.exports = mode; | ||
| } | ||
|
|
||
| // else take webpack default | ||
| else { | ||
| mode = 'production'; | ||
| } | ||
| return { | ||
| entry: {main: ['@babel/polyfill', 'whatwg-fetch', './src/index.js']}, | ||
| output: { | ||
| path: path.resolve(__dirname, dashLibraryName), | ||
| filename: | ||
| mode === 'development' | ||
| ? `${dashLibraryName}.dev.js` | ||
| : `${dashLibraryName}.min.js`, | ||
| library: dashLibraryName, | ||
| libraryTarget: 'window', | ||
| }, | ||
| devtool: 'source-map', | ||
| externals: { | ||
| react: 'React', | ||
| 'react-dom': 'ReactDOM', | ||
| 'plotly.js': 'Plotly', | ||
| 'prop-types': 'PropTypes' | ||
| }, | ||
| module: { | ||
| rules: [ | ||
| { | ||
| test: /\.js$/, | ||
| exclude: /node_modules/, | ||
| use: { | ||
| loader: 'babel-loader', | ||
| }, | ||
| }, | ||
| { | ||
| test: /\.css$/, | ||
| use: [ | ||
| { | ||
| loader: 'style-loader', | ||
| }, | ||
| { | ||
| loader: 'css-loader', | ||
| }, | ||
| ], | ||
| const defaultOptions = { | ||
| mode: 'development', | ||
| devtool: 'none', | ||
| entry: { | ||
| main: ['@babel/polyfill', 'whatwg-fetch', './src/index.js'], | ||
| }, | ||
| output: { | ||
| path: path.resolve(__dirname, dashLibraryName), | ||
| filename: `${dashLibraryName}.dev.js`, | ||
| library: dashLibraryName, | ||
| libraryTarget: 'window', | ||
| }, | ||
| externals: { | ||
| react: 'React', | ||
| 'react-dom': 'ReactDOM', | ||
| 'plotly.js': 'Plotly', | ||
| 'prop-types': 'PropTypes', | ||
| }, | ||
| plugins: [], | ||
| module: { | ||
| rules: [ | ||
| { | ||
| test: /\.js$/, | ||
| exclude: /node_modules/, | ||
| use: { | ||
| loader: 'babel-loader', | ||
| }, | ||
| { | ||
| test: /\.svg$/, | ||
| use: ['@svgr/webpack'] | ||
| }, | ||
| { | ||
| test: /\.txt$/i, | ||
| use: 'raw-loader', | ||
| }, | ||
| { | ||
| test: /\.css$/, | ||
| use: [ | ||
| { | ||
| loader: 'style-loader', | ||
| }, | ||
| { | ||
| loader: 'css-loader', | ||
| }, | ||
| ], | ||
| }, | ||
| { | ||
| test: /\.svg$/, | ||
| use: ['@svgr/webpack'], | ||
| }, | ||
| { | ||
| test: /\.txt$/i, | ||
| use: 'raw-loader', | ||
| }, | ||
| ], | ||
| }, | ||
| }; | ||
|
|
||
| module.exports = (_, argv) => { | ||
| const devtool = argv.build === 'local' ? 'source-map' : 'none'; | ||
| return [ | ||
| R.mergeDeepLeft({devtool}, defaultOptions), | ||
| R.mergeDeepLeft( | ||
| { | ||
| devtool: devtool, | ||
| mode: 'production', | ||
| output: { | ||
| filename: `${dashLibraryName}.min.js`, | ||
| }, | ||
| ], | ||
| }, | ||
| plugins: [ | ||
| new webpack.NormalModuleReplacementPlugin( | ||
| /(.*)GlobalErrorContainer.react(\.*)/, | ||
| function(resource) { | ||
| if (mode === 'production') { | ||
| resource.request = resource.request.replace( | ||
| /GlobalErrorContainer.react/, | ||
| 'GlobalErrorContainerPassthrough.react' | ||
| ); | ||
| } | ||
| } | ||
| ), | ||
| ], | ||
| }; | ||
| plugins: [ | ||
| new webpack.NormalModuleReplacementPlugin( | ||
| /(.*)GlobalErrorContainer.react(\.*)/, | ||
| function(resource) { | ||
| resource.request = resource.request.replace( | ||
| /GlobalErrorContainer.react/, | ||
| 'GlobalErrorContainerPassthrough.react' | ||
| ); | ||
| } | ||
| ), | ||
| ], | ||
| }, | ||
| defaultOptions | ||
| ), | ||
| ]; | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters