Error when no layout is present. #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did the pylint tests change for python3? Never had those circleci failures before. |
|
💃 once tests pass |
|
💃 Is this the same reason #286 (comment) the tests are failing? |
|
I think so, they were all pylint errors. I'll just make the fixes it reports or add ignores |
T4rk1n
reviewed
Jul 18, 2018
| 'The layout was `None` ' | ||
| 'at the time that `run_server` was called. ' | ||
| 'Make sure to set the `layout` attribute of your application ' | ||
| 'before running the server.') |
There was a problem hiding this comment.
good point, looks like it will also work in _setup_server
|
I don't have the ability to merge on this repo. Can someone merge / give me permission? |
@rmarren1 - I finally tracked this one down. Could you try now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #220, #287