Create Checklist and RadioItems labels with titles #3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giladmaya
force-pushed
the
add-title-to-checklist-and-radioitem
branch
2 times, most recently
from
5b5a6ca
to
d5a97fb
Compare
giladmaya
requested review from
alexcjohnson,
T4rk1n,
ndrezn,
gvwilson and
emilykl
as code owners
gvwilson
added
feature
T4rk1n
reviewed
Nov 13, 2024
...omponents/tests/integration/dropdown/test_dropdown_radioitems_checklist_option_title_prop.py
Outdated
Show resolved
Hide resolved
...omponents/tests/integration/dropdown/test_dropdown_radioitems_checklist_option_title_prop.py
Outdated
Show resolved
Hide resolved
...omponents/tests/integration/dropdown/test_dropdown_radioitems_checklist_option_title_prop.py
Outdated
Show resolved
Hide resolved
giladmaya
force-pushed
the
add-title-to-checklist-and-radioitem
branch
5 times, most recently
from
46e2d0c
to
14c8a23
Compare
I've addressed all your comments and pushed the changes. Can you please re-review? Thank you |
T4rk1n
approved these changes
Nov 22, 2024
giladmaya
force-pushed
the
add-title-to-checklist-and-radioitem
branch
from
b6a725a
to
ff244d3
Compare
@T4rk1n I've tried re-triggering the failed tests but it seems like there's some instability with them, which as far as I can tell isn't related to my code changes. Can you please have a look? Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1847 and adds a title to the Checklist and RadioItems options
Contributor Checklist