-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
adding support for async callbacks and page layouts #3089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 46 commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
e1002d5
adding support for async callbacks and page layouts
BSd3v e24e094
adding new `use_async` attribute to `Dash` and having callbacks and l…
BSd3v 5d492dc
fixing issue with indentations of layouts
BSd3v 69ee069
removing needing to classify the function as async, instead I am look…
BSd3v 950888c
fixing for lint
BSd3v 916efdc
adjustments for the test for the debugger, making test more robust fo…
BSd3v 0dd778e
fixing lint issues
BSd3v 2d9a930
Adjustments for `use_async` and determining whether the app can be us…
BSd3v b2f9cd6
disable lint for unused import on `asgiref`
BSd3v f1ac667
adjustments for formatting
BSd3v 378099f
Merge remote-tracking branch 'dash/dev' into support-async-callbacks
BSd3v 52de22e
adding additional ignore for `flake8`
BSd3v 4189ed6
more adjustments for lint
BSd3v 0ddf254
adding `dash[async]`
BSd3v 76a9a56
Merge branch 'plotly:dev' into support-async-callbacks
BSd3v 337ec26
attempt no 1 for refactoring dash for `dispatch`
BSd3v a730b4b
fixing for lint
BSd3v 538515d
fixing no outputs
BSd3v 4f14a1a
attempt no 1 for refactoring callbacks
BSd3v 96df44e
fixing for multi outputs
BSd3v 91400a3
attempt no 1 refactoring background callbacks for async functions
BSd3v 1856f5c
Merge remote-tracking branch 'dash/dev' into support-async-callbacks
BSd3v 671cb2b
fixing for lint and progress outputs
BSd3v f19fe23
lint adjustments
BSd3v 17c824d
adding async tests
fdfd058
bypassing `test_rdrh003_refresh_jwt` as this fails with 3 failed requ…
fb691c3
removing `__init__` from `async` directory
2473546
adjusting `jwt` test to adjust value in the MultiProcessing and remov…
b2e8884
removing flaky for lint
df29ee6
adjustments for formatting
5342573
simplifying `jwt` test by using `before_request` removing needs to ch…
c79debf
attempting to allow for failed tests to be rerun to see if the cache …
37d649c
moving retry to `integration-dash`
eaec04f
adjusting browser for percy snapshot to append `async` to the snapsho…
68320f4
fixing `browser` for lint
5b201a1
Merge branch 'dev' into support-async-callbacks
BSd3v 1aea686
Merge remote-tracking branch 'remote/dev' into support-async-callbacks
BSd3v fc6c6bc
updating missing `long` -> `background` adjustments and fixing issue …
BSd3v 503f7c0
fixing for lint
BSd3v c26671e
adding tests for async background callbacks
BSd3v 20dcd67
updating to bypass test if not async
BSd3v bb3d881
fixing for lint
BSd3v c6940c7
update for celery app process
BSd3v b7a8c4a
Merge branch 'dev' into support-async-callbacks
BSd3v 51c1689
Merge branch 'dev' into support-async-callbacks
BSd3v eb96c5d
Merge branch 'dev' into support-async-callbacks
BSd3v 832ab4d
Merge remote-tracking branch 'remote/dev' into support-async-callbacks
BSd3v d0b2dd3
fixing tyop
BSd3v e88bc3c
fixing for issues with callback structure
BSd3v a1bd54f
Update dash/_callback.py
BSd3v 7f35ecd
adjusting issue with try
BSd3v 28b0693
Merge branch 'support-async-callbacks' of github.com:BSd3v/dash into …
BSd3v 443f785
removing `test_async` from the utils to keep from confusing `pytest`
BSd3v 07bcd38
fixing for lint
BSd3v e82f561
updates for new `background_callbacks` test path
BSd3v 43fe153
adjustment for GHA to run the async test
BSd3v 6fd556d
adding step for creating the test components
BSd3v abbfcd2
altering path for the get background callback manager
BSd3v 13a33be
verifying redis is still running
BSd3v e3a1496
issue with celery
BSd3v e8bcb22
adjusting order
BSd3v 43d10c4
attempt to fix failing test
BSd3v 4b3c011
moving async install
BSd3v 777a12b
adding test components
BSd3v 769fc7e
remove async test from circleci
T4rk1n 12574d1
move async tests
T4rk1n 3c610b3
remove integrations tests from async_tests
T4rk1n d955ce1
fix async_tests
T4rk1n 513408d
fix async tests
T4rk1n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move the new tests to a github action, maybe bundled with the background tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GHA werent implemented when this was originally created, I can look into adjusting the yaml for that.