Skip to content

Percy #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2019
Merged

Percy #138

merged 1 commit into from
Nov 4, 2019

Conversation

@byronz
Copy link
Contributor

@byronz byronz commented Nov 4, 2019

No description provided.

@byronz byronz marked this pull request as ready for review November 4, 2019 16:53
@rpkyle rpkyle changed the base branch from master to dev November 4, 2019 16:54
@rpkyle
Copy link
Contributor

rpkyle commented Nov 4, 2019

@byronz I'd merge this into dev first, but you could merge into master with some changes. Up to you.

@byronz
Copy link
Contributor Author

byronz commented Nov 4, 2019 •
edited
Loading

@rpkyle @alexcjohnson
this PR contains the correct way to configure the Percy with --nopercyfinalize
and it looks like the npx percy way is working now

https://percy.io/plotly/dashR

@byronz
Copy link
Contributor Author

byronz commented Nov 4, 2019

@byronz I'd merge this into dev first, but you could merge into master with some changes. Up to you.

was targeting the wrong base .

@byronz byronz mentioned this pull request Nov 4, 2019
Closed
@byronz byronz merged commit 5d485d9 into dev Nov 4, 2019
@byronz byronz deleted the percy branch November 4, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@byronz @rpkyle