Send status code of 1 when unit tests fail #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpkyle
added
the
testing
rpkyle
added a commit
that referenced
this pull request
Feb 13, 2020
* Autoset routes and requests pathname prefixes (#165) * Inspect environment variables for host & port (#167) * Support for index page templating (#168) * Add support for config-aware relative paths (#172) * Add unit tests for index customization (#176) * Send status code of 1 when unit tests fail (#177)
rpkyle
added a commit
that referenced
this pull request
May 6, 2020
* Add unit tests for index customization (#176) * Send status code of 1 when unit tests fail (#177) * Support for arbitrary file extensions (#186) * Add assortment of unit tests to Dash for R (#179) * Nested and standard components test (#191) * Support inline clientside callbacks in Dash for R (#140) * Speed up CI, use image from plotly * Update to dash-renderer 1.4.1 Co-authored-by: HammadTheOne <hammadkhan@plotly.com> Co-authored-by: Marc-André Rivet <marc-andre.rivet@plotly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the unit test failures aren't properly detected in CI, as noted in #152. This is a limitation of the
testthatpackage, which does not send a failure code even when tests have failed.The proposed edit to the CircleCI config should properly trigger a failure code; this PR will trigger an error initially to test whether the change works as intended.
Closes #152.
@Marc-Andre-Rivet