Skip to content

improve search link for array properties #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 27, 2018

Conversation

michaelbabyn
Copy link
Contributor

@michaelbabyn michaelbabyn commented Sep 4, 2018

Fixes #1064

@michaelbabyn michaelbabyn added the ReviewReady This PR is ready for review label Sep 4, 2018
@michaelbabyn michaelbabyn requested a review from cldougl September 4, 2018 18:03
@michaelbabyn
Copy link
Contributor Author

I noticed that any nested attributes deeper than 4 or 5 levels didn't get added to the angolia search so I also updated the ref_search script so that it doesn't max out. Now this PR also fixes #925.

Copy link
Member

@cldougl cldougl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @michaelbabyn !
💃

@cldougl cldougl removed the ReviewReady This PR is ready for review label Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants