-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added retry logic to HTTP requests #1656
Conversation
Thank you for the PR, and sorry for delayed response! That'd be great if you could revert the whitespace changes. Also, I think you missed this call to |
Thanks. I've reverted all of the whitespace changes and replaced the |
Sorry for the delay in getting this merged @jameslamb, this is looking good, and I'd be happy to take it on. Just a couple minor nitpicks:
|
will do, thanks for the review! |
Ok I just made the requested changes in 1bf6a4a. I've also rebased to |
Awesome, thank you! One last request: could you add a NEWS.md item (under improvements)? |
Sure! Just added in 0f1f181 I also fixed a missing comma from my last commit, which I think was the reason Travis was ❌ |
Thanks for this awesome project!
In this PR, I'd like to propose swapping out calls to
httr::GET()
,httr::PATCH()
, etc. withhttr::RETRY()
. This will make the package more resilient to transient problems like brief network outages or periods where the service(s) it hits are overwhelmed. In my experience, using retry logic almost always improves the user experience with HTTP clients.I apologize for the whitespace changes. I have my editor set to trim excess horizontal whitespace when I save files. If you'd like me to revert those please let me know.