fix: implement automatic zorder assignment for proper trace layering #2445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the box plot layering issue where box plots always rendered behind other traces (ribbons, lines) despite correct layer ordering in ggplot2. Implements automatic zorder assignment based on ggplot2 layer order using new plotly.js functionality
- Add comprehensive test coverage for zorder functionality - Test both scenarios: with and without automatic zorder assignment - Includes visual regression tests with SVG snapshots - Verifies boxplot renders correctly on top of confidence intervals - Addresses issue where box plots rendered behind other traces 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Box Plot Layering Fix - Summary
Problem
Fix box plot layering issue where box plots always rendered behind other traces (ribbons, lines) despite correct layer ordering in ggplot2.
Solution
Changes Made
1. Core Fix (R/ggplotly.R:1153-1162)
Added automatic zorder assignment loop that assigns sequential zorder values (zorder = i) to each trace based on their position in the data array.
2. plotly.js Update
Updated to v3.0.1 to support zorder functionality.
3. Test Coverage
Added test cases with visual regression tests to verify boxplot layering behavior.