sub onGraphLogging with notifyOnLogging

plotly · Jan 6, 2020 · 2bff896 · 2bff896
1 parent 75a7414
commit 2bff896
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/src/lib/loggers.js b/src/lib/loggers.js
@@ -33,7 +33,7 @@ loggers.log = function() {
  apply(console.trace || console.log, messages);
  }
 
- if(dfltConfig.onGraphLogging > 1) {
+ if(dfltConfig.notifyOnLogging > 1) {
  var lines = [];
  for(i = 0; i < arguments.length; i++) {
  lines.push(arguments[i]);
@@ -53,7 +53,7 @@ loggers.warn = function() {
  apply(console.trace || console.log, messages);
  }
 
- if(dfltConfig.onGraphLogging > 0) {
+ if(dfltConfig.notifyOnLogging > 0) {
  var lines = [];
  for(i = 0; i < arguments.length; i++) {
  lines.push(arguments[i]);
@@ -73,7 +73,7 @@ loggers.error = function() {
  apply(console.error, messages);
  }
 
- if(dfltConfig.onGraphLogging > 0) {
+ if(dfltConfig.notifyOnLogging > 0) {
  var lines = [];
  for(i = 0; i < arguments.length; i++) {
  lines.push(arguments[i]);

diff --git a/src/plot_api/plot_config.js b/src/plot_api/plot_config.js
@@ -390,7 +390,7 @@ var configAttributes = {
  ].join(' ')
  },
 
- onGraphLogging: {
+ notifyOnLogging: {
  valType: 'integer',
  min: 0,
  max: 2,

diff --git a/test/jasmine/tests/lib_test.js b/test/jasmine/tests/lib_test.js
@@ -1704,13 +1704,13 @@ describe('Test lib.js:', function() {
  beforeEach(function() {
  stashConsole = window.console;
  stashLogLevel = config.logging;
- stashOnGraphLogLevel = config.onGraphLogging;
+ stashOnGraphLogLevel = config.notifyOnLogging;
  });
 
  afterEach(function() {
  window.console = stashConsole;
  config.logging = stashLogLevel;
- config.onGraphLogging = stashOnGraphLogLevel;
+ config.notifyOnLogging = stashOnGraphLogLevel;
  });
 
  it('emits one console message if apply is available', function() {
@@ -1811,7 +1811,7 @@ describe('Test lib.js:', function() {
  ]);
  });
 
- describe('should log message in notifier div in accordance onGraphLogging config option', function() {
+ describe('should log message in notifier div in accordance notifyOnLogging config option', function() {
  var query = '.notifier-note';
 
  beforeEach(function(done) {
@@ -1840,17 +1840,17 @@ describe('Test lib.js:', function() {
  }
 
  it('with level 2', function() {
- config.onGraphLogging = 2;
+ config.notifyOnLogging = 2;
  _run(['log', 'warn', 'error!']);
  });
 
  it('with level 1', function() {
- config.onGraphLogging = 1;
+ config.notifyOnLogging = 1;
  _run(['warn', 'error!']);
  });
 
  it('with level 0', function() {
- config.onGraphLogging = 0;
+ config.notifyOnLogging = 0;
  _run([]);
  });
  });