pie & sunburst: pass empty text string to texttemplate

plotly · Sep 10, 2019 · 2e966e0 · etpinard · Sep 10, 2019 · antoinerg
1 parent 9b4a38d
commit 2e966e0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/traces/pie/plot.js b/src/traces/pie/plot.js
@@ -991,8 +991,8 @@ function formatSliceLabel(gd, pt, cd0) {
             pt.text = '';
         } else {
             var obj = makeTemplateVariables(pt);
-            var ptTx = helpers.getFirstFilled(trace.text, pt.pts);
-            if(isValidTextValue(ptTx)) obj.text = ptTx;
+            var ptTx = Lib.castOption(trace, pt.i, 'text');
+            if(isValidTextValue(ptTx) || ptTx === '') obj.text = ptTx;
             pt.text = Lib.texttemplateString(txt, obj, gd._fullLayout._d3locale, obj, trace._meta || {});
         }
     }

diff --git a/src/traces/sunburst/plot.js b/src/traces/sunburst/plot.js
@@ -718,7 +718,7 @@ function formatSliceLabel(pt, trace, fullLayout) {
         obj.color = cdi.color;
     }
     var ptTx = Lib.castOption(trace, cdi.i, 'text');
-    if(Lib.isValidTextValue(ptTx)) obj.text = ptTx;
+    if(Lib.isValidTextValue(ptTx) || ptTx === '') obj.text = ptTx;
     obj.customdata = Lib.castOption(trace, cdi.i, 'customdata');
     return Lib.texttemplateString(txt, obj, fullLayout._d3locale, obj, trace._meta || {});
 }