Add line select baseline

plotly · Feb 16, 2018 · 41c067a · 41c067a
1 parent 42a7c77
commit 41c067a
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 7 deletions.
diff --git a/src/traces/scattergl/index.js b/src/traces/scattergl/index.js
@@ -591,7 +591,7 @@ function sceneUpdate(container, subplot) {
             }
 
             // draw traces in selection mode
-            if(scene.select2d && scene.selectBatch) {
+            if(scene.scatter2d && scene.select2d && scene.selectBatch) {
                 scene.select2d.draw(scene.selectBatch);
                 scene.scatter2d.draw(scene.unselectBatch);
             }
@@ -947,12 +947,17 @@ function plot(container, subplot, cdata) {
             scene.select2d = createScatter(layout._glcanvas.data()[1].regl, {clone: scene.scatter2d});
         }
 
-        // update only traces with selection
-        scene.scatter2d.update(scene.unselectedOptions.map(function(opts, i) {
-            return scene.selectBatch[i] ? opts : null;
-        }));
-        scene.select2d.update(scene.markerOptions);
-        scene.select2d.update(scene.selectedOptions);
+        if(scene.scatter2d) {
+            // update only traces with selection
+            scene.scatter2d.update(scene.unselectedOptions.map(function(opts, i) {
+                return scene.selectBatch[i] ? opts : null;
+            }));
+        }
+
+        if(scene.select2d) {
+            scene.select2d.update(scene.markerOptions);
+            scene.select2d.update(scene.selectedOptions);
+        }
     }
 
     // uploat viewport/range data to GPU

diff --git a/test/image/mocks/gl2d_line_select.json b/test/image/mocks/gl2d_line_select.json
@@ -0,0 +1,14 @@
+{
+    "data": [{
+        "type": "scattergl",
+        "mode": "lines",
+        "x": [1, 2, 3],
+        "y": [1, 2, 1]
+    }],
+    "layout": {
+        "dragmode": "select",
+        "showlegend": false,
+        "width": 400,
+        "height": 400
+    }
+}