stop filling new [] in pie defaults

plotly · Feb 8, 2018 · 564dff6 · 564dff6 · etpinard · Feb 8, 2018
1 parent 3178b2e
commit 564dff6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/traces/pie/calc.js b/src/traces/pie/calc.js
@@ -18,7 +18,7 @@ module.exports = function calc(gd, trace) {
  var vals = trace.values;
  var hasVals = Array.isArray(vals) && vals.length;
  var labels = trace.labels;
- var colors = trace.marker.colors;
+ var colors = trace.marker.colors || [];
  var cd = [];
  var fullLayout = gd._fullLayout;
  var colorWay = fullLayout.colorway;

diff --git a/src/traces/pie/defaults.js b/src/traces/pie/defaults.js
@@ -34,8 +34,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
  var lineWidth = coerce('marker.line.width');
  if(lineWidth) coerce('marker.line.color');
 
- var colors = coerce('marker.colors');
- if(!Array.isArray(colors)) traceOut.marker.colors = [];
+ coerce('marker.colors');
 
  coerce('scalegroup');
  // TODO: hole needs to be coerced to the same value within a scaleegroup