Skip to content

Commit

Permalink
Add "between to newshape.layer as well.
Browse files Browse the repository at this point in the history
Make line length of description shorter.
  • Loading branch information
my-tien committed Mar 21, 2024
1 parent 2b398d3 commit 70ebe72
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 6 deletions.
5 changes: 4 additions & 1 deletion src/components/shapes/attributes.js
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,10 @@ module.exports = templatedArray('shape', {
values: ['below', 'above', 'between'],
dflt: 'above',
editType: 'arraydraw',
description: 'Specifies whether shapes are drawn below gridlines (*below*), between gridlines and traces (*between*) or above traces (*above*).'
description: [
'Specifies whether shapes are drawn below gridlines (*below*),',
'between gridlines and traces (*between*) or above traces (*above*).'
]
},

xref: extendFlat({}, annAttrs.xref, {
Expand Down
7 changes: 5 additions & 2 deletions src/components/shapes/draw_newshape/attributes.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,12 @@ module.exports = overrideAll({
},
layer: {
valType: 'enumerated',
values: ['below', 'above'],
values: ['below', 'above', 'between'],
dflt: 'above',
description: 'Specifies whether new shapes are drawn below or above traces.'
description: [
'Specifies whether new shapes are drawn below gridlines (*below*),',
'between gridlines and traces (*between*) or above traces (*above*).'
]
},
drawdirection: {
valType: 'enumerated',
Expand Down
13 changes: 10 additions & 3 deletions test/plot-schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -3720,13 +3720,17 @@
}
},
"layer": {
"description": "Specifies whether new shapes are drawn below or above traces.",
"description": [
"Specifies whether new shapes are drawn below gridlines (*below*),",
"between gridlines and traces (*between*) or above traces (*above*)."
],
"dflt": "above",
"editType": "none",
"valType": "enumerated",
"values": [
"below",
"above"
"above",
"between"
]
},
"legend": {
Expand Down Expand Up @@ -7708,7 +7712,10 @@
}
},
"layer": {
"description": "Specifies whether shapes are drawn below gridlines (*below*), between gridlines and traces (*between*) or above traces (*above*).",
"description": [
"Specifies whether shapes are drawn below gridlines (*below*),",
"between gridlines and traces (*between*) or above traces (*above*)."
],
"dflt": "above",
"editType": "arraydraw",
"valType": "enumerated",
Expand Down

0 comments on commit 70ebe72

Please sign in to comment.