Skip to content

Commit

Permalink
add outside ticks to multicategory2 mock
Browse files Browse the repository at this point in the history
... to show divider span bug, update baseline using 1.49.4
  • Loading branch information
etpinard committed Sep 4, 2019
1 parent d54ec94 commit a7e8eaf
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
2 changes: 2 additions & 0 deletions src/plots/cartesian/axes.js
Original file line number Diff line number Diff line change
Expand Up @@ -1799,6 +1799,8 @@ axes.drawOne = function(gd, ax, opts) {
var pad = {x: 2, y: 10}[axLetter];
var sgn = tickSigns[2] * (ax.ticks === 'inside' ? -1 : 1);

// TODO missing 'ax.ticklen` part when tickson:'labels'

seq.push(function() {
labelLength += getLabelLevelSpan(ax, axId + 'tick') + pad;
labelLength += ax._tickAngles[axId + 'tick'] ? ax.tickfont.size * LINE_SPACING : 0;
Expand Down
Binary file modified test/image/baselines/multicategory2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 5 additions & 3 deletions test/image/mocks/multicategory2.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,12 @@
],
"layout": {
"xaxis": {
"title": "MULTI-CATEGORY ON TOP",
"title": {"text": "MULTI-CATEGORY ON TOP"},
"side": "top",
"automargin": true,
"tickson": "labels"
"tickson": "labels",
"ticks": "outside",
"ticklen": 25,
"automargin": true
},
"showlegend": false,
"width": 400,
Expand Down

0 comments on commit a7e8eaf

Please sign in to comment.