Skip to content

annotation placement for ordinal axis bugs with version 1.20 #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Quath opened this issue Nov 16, 2016 · 6 comments · Fixed by #1155
Closed

annotation placement for ordinal axis bugs with version 1.20 #1154

Quath opened this issue Nov 16, 2016 · 6 comments · Fixed by #1155
Labels
bug something broken

Comments

@Quath
Copy link

Quath commented Nov 16, 2016

Hi

I have a bar graph which had on the X axis a combination of 2 date strings ("04/2014") and text strings ("Status", "Difference", ...). On top of each bar was an annotation. The annotations were all defined the following way:
let annotation = { x: "mystring", y: 2354, text: "blabla", xanchor: middle, yanchor: top, }
with "mystring" being either one of the date strings, or one of the text strings.

With version 1.19.x I had no trouble, the annotations where all placed nicely on top of the bars, with the upgrade to version 1.20.x, all the annotations are placed in the X middle of the graph... The code itself didn't change between the upgrade...

Any idea?

@etpinard
Copy link
Contributor

Can you share a reproducible example?

This is probably a side-effect of #1078

@Quath
Copy link
Author

Quath commented Nov 16, 2016

Working !!! (yeeey for once I manage to reproduce the error!!!)
https://fiddle.jshell.net/Quath/8hd4p8nu/

@etpinard
Copy link
Contributor

https://fiddle.jshell.net/8hd4p8nu/3/

is now showing a graph. What's wrong with it?

@Quath
Copy link
Author

Quath commented Nov 16, 2016

The annotations are in the center of the graph, and not on the bars...
I expect the annotations to be at least within the bars if not on top

@etpinard
Copy link
Contributor

I see. The annotation reference x / y categories. This is regression.

Thanks for posting!

@etpinard etpinard added the bug something broken label Nov 16, 2016
@Quath
Copy link
Author

Quath commented Nov 16, 2016

You're welcome!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants