Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation text not getting placed correctly on relayout when page is scrolled #1678

Closed
etpinard opened this issue May 12, 2017 · 2 comments · Fixed by #1683
Closed

Annotation text not getting placed correctly on relayout when page is scrolled #1678

etpinard opened this issue May 12, 2017 · 2 comments · Fixed by #1683
Assignees
Labels
bug something broken

Comments

@etpinard
Copy link
Contributor

etpinard commented May 12, 2017

First reported in https://community.plot.ly/t/text-move-to-wrong-position-when-scrolling-update-or-relayout-graph/4209

🆘 This is a regression 1.27.0 🆘

From http://codepen.io/plotly/pen/Kzjamd?editors=0011

  • make the page scrollable (e.g. by opening the codePen console)
  • click on a point, get an annotation (this works)
  • scroll down
  • click on a point, now the annotation text nodes are misplaced
  • scroll up
  • click on a point, now all the annotation text nodes are placed properly

peek 2017-05-12 10-26


I can't find anything suspicious in the 1.27.0 changelog. Maybe the Drawing optimisations of #1585 are to blame?

@etpinard etpinard added the bug something broken label May 12, 2017
@etpinard etpinard changed the title Annotation text not getting placed on relayout when page is scrolled Annotation text not getting placed correctly on relayout when page is scrolled May 12, 2017
@rreusser
Copy link
Contributor

rreusser commented May 12, 2017

Hmm. What about the textpoint class? That could possibly have an effect on the transform/x/y properties.

Edit: never mind. This is annotations, not text traces. Hmm.

@etpinard
Copy link
Contributor Author

etpinard commented May 12, 2017

This regression is indeed caused by 29abb5d of PR #1585

I'm not sure why though. I'll try to come up with a test case.

etpinard added a commit that referenced this issue May 12, 2017
- to simulate report #1678
@etpinard etpinard self-assigned this May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants