Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updatemenu scroll handle has the wrong size #1859

Closed
alexcjohnson opened this issue Jul 7, 2017 · 5 comments
Closed

Updatemenu scroll handle has the wrong size #1859

alexcjohnson opened this issue Jul 7, 2017 · 5 comments
Labels
bug something broken

Comments

@alexcjohnson
Copy link
Collaborator

alexcjohnson commented Jul 7, 2017

(Edit: this has been fixed for legend, still an issue for updatemenus)
Look for example at the legend_scroll mock: there are 23 traces, and 13 are visible at a time in the legend. So the scroll handle should take up ~13/23 of the legend height. But it looks like it just has a fixed height of 20px (which might be reasonable as a minimum in case the legend is absurdly long relative to its viewport, unless the viewport itself is super small, then the minimum might drop to half its height?)
screen shot 2017-07-07 at 1 37 52 am

I think updatemenu scroll handles do the same thing but have not observed it.

@alexcjohnson alexcjohnson added the bug something broken label Jul 7, 2017
@n-riesco
Copy link
Contributor

n-riesco commented Jul 7, 2017

@alexcjohnson Both legends and updatemenus use constant-sized scrollbars.

@alexcjohnson
Copy link
Collaborator Author

Thanks @n-riesco - It's not super high priority (I called it a bug not because it's broken, but because it's different from basically every other scrollbar out there), but do you want to take this one when you need a break from other work? Should be easy...

@n-riesco
Copy link
Contributor

n-riesco commented Jul 7, 2017

@alexcjohnson sure, I can look into it (as long as this isn't urgent).

alexcjohnson added a commit that referenced this issue Feb 28, 2018
@alexcjohnson
Copy link
Collaborator Author

#2426 fixed the legends part of this.
Updatemenus do have this problem too, so leaving this issue open.

@alexcjohnson alexcjohnson changed the title Legend (and updatemenu?) scroll handle has the wrong size Updatemenu scroll handle has the wrong size Mar 6, 2018
@gvwilson
Copy link
Contributor

Hi - this issue has been sitting for a while, so as part of our effort to tidy up our public repositories I'm going to close it. If it's still a concern, we'd be grateful if you could open a new issue (with a short reproducible example if appropriate) so that we can add it to our stack. Cheers - @gvwilson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

3 participants